[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] xen: add vkbd support for PV on HVM guests
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-devel] [PATCH 2/2] xen: add vkbd support for PV on HVM guests |
|
Date: |
Fri, 24 Jun 2011 16:19:08 +0100 |
On 24 June 2011 15:54, <address@hidden> wrote:
> + if (!in->c.ds) {
> + char *vfb = xenstore_read_str(NULL, "device/vfb");
> + if (vfb == NULL) {
> + /* there is no vfb, run vkbd on its own */
> + in->c.ds = get_displaystate();
> + } else {
> + free(vfb);
xenstore_read_str() returns a pointer from a qemu_strdup()
so strictly this should be a qemu_free(), I think?
-- PMM