qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 08/11] usb-ehci: Fix handling of PED and PEDC po


From: Brad Hards
Subject: Re: [Qemu-devel] [PATCH 08/11] usb-ehci: Fix handling of PED and PEDC port status bits
Date: Sat, 25 Jun 2011 10:15:41 +1000
User-agent: KMail/1.13.6 (Linux/2.6.38-8-generic; KDE/4.6.2; x86_64; ; )

5/11 does this:
-#define PORTSC_RO_MASK       0x007021c5
+#define PORTSC_RO_MASK       0x007021c4

before 8/11 does this:
> -#define PORTSC_RO_MASK       0x007021c4
> +#define PORTSC_RO_MASK       0x007021c0

You could push those together if there was a v2. I don't think its important 
though.

Even nicer would be to build it out of symbolic constants / defines, so its 
obvious what is being masked.

Brad




reply via email to

[Prev in Thread] Current Thread [Next in Thread]