[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [RFC v2 17/20] cirrus: simplify bitblt BAR access functions
From: |
Avi Kivity |
Subject: |
[Qemu-devel] [RFC v2 17/20] cirrus: simplify bitblt BAR access functions |
Date: |
Mon, 27 Jun 2011 16:22:04 +0300 |
Make use of the memory API's ability to satisfy multi-byte accesses via
multiple single-byte accesses.
Signed-off-by: Avi Kivity <address@hidden>
---
hw/cirrus_vga.c | 87 ++++++++++--------------------------------------------
1 files changed, 16 insertions(+), 71 deletions(-)
diff --git a/hw/cirrus_vga.c b/hw/cirrus_vga.c
index 0cb34d9..6312c6e 100644
--- a/hw/cirrus_vga.c
+++ b/hw/cirrus_vga.c
@@ -2445,39 +2445,27 @@ static void cirrus_linear_write(MemoryRegion *mr,
target_phys_addr_t addr,
***************************************/
-static uint32_t cirrus_linear_bitblt_readb(void *opaque, target_phys_addr_t
addr)
+static uint64_t cirrus_linear_bitblt_read(MemoryRegion *mr,
+ target_phys_addr_t addr,
+ unsigned size)
{
+ CirrusVGAState *s = container_of(mr, CirrusVGAState,
+ cirrus_linear_bitblt_io);
uint32_t ret;
/* XXX handle bitblt */
+ (void)s;
ret = 0xff;
return ret;
}
-static uint32_t cirrus_linear_bitblt_readw(void *opaque, target_phys_addr_t
addr)
-{
- uint32_t v;
-
- v = cirrus_linear_bitblt_readb(opaque, addr);
- v |= cirrus_linear_bitblt_readb(opaque, addr + 1) << 8;
- return v;
-}
-
-static uint32_t cirrus_linear_bitblt_readl(void *opaque, target_phys_addr_t
addr)
-{
- uint32_t v;
-
- v = cirrus_linear_bitblt_readb(opaque, addr);
- v |= cirrus_linear_bitblt_readb(opaque, addr + 1) << 8;
- v |= cirrus_linear_bitblt_readb(opaque, addr + 2) << 16;
- v |= cirrus_linear_bitblt_readb(opaque, addr + 3) << 24;
- return v;
-}
-
-static void cirrus_linear_bitblt_writeb(void *opaque, target_phys_addr_t addr,
- uint32_t val)
+static void cirrus_linear_bitblt_write(MemoryRegion *mr,
+ target_phys_addr_t addr,
+ uint64_t val,
+ unsigned size)
{
- CirrusVGAState *s = opaque;
+ CirrusVGAState *s = container_of(mr, CirrusVGAState,
+ cirrus_linear_bitblt_io);
if (s->cirrus_srcptr != s->cirrus_srcptr_end) {
/* bitblt */
@@ -2488,57 +2476,14 @@ static void cirrus_linear_bitblt_writeb(void *opaque,
target_phys_addr_t addr,
}
}
-static void cirrus_linear_bitblt_writew(void *opaque, target_phys_addr_t addr,
- uint32_t val)
-{
- cirrus_linear_bitblt_writeb(opaque, addr, val & 0xff);
- cirrus_linear_bitblt_writeb(opaque, addr + 1, (val >> 8) & 0xff);
-}
-
-static void cirrus_linear_bitblt_writel(void *opaque, target_phys_addr_t addr,
- uint32_t val)
-{
- cirrus_linear_bitblt_writeb(opaque, addr, val & 0xff);
- cirrus_linear_bitblt_writeb(opaque, addr + 1, (val >> 8) & 0xff);
- cirrus_linear_bitblt_writeb(opaque, addr + 2, (val >> 16) & 0xff);
- cirrus_linear_bitblt_writeb(opaque, addr + 3, (val >> 24) & 0xff);
-}
-
-static uint64_t cirrus_linear_bitblt_read(MemoryRegion *mr,
- target_phys_addr_t addr,
- unsigned size)
-{
- CirrusVGAState *s = container_of(mr, CirrusVGAState,
- cirrus_linear_bitblt_io);
-
- switch (size) {
- case 1: return cirrus_linear_bitblt_readb(s, addr);
- case 2: return cirrus_linear_bitblt_readw(s, addr);
- case 4: return cirrus_linear_bitblt_readl(s, addr);
- default: abort();
- }
-};
-
-static void cirrus_linear_bitblt_write(MemoryRegion *mr,
- target_phys_addr_t addr,
- uint64_t data,
- unsigned size)
-{
- CirrusVGAState *s = container_of(mr, CirrusVGAState,
- cirrus_linear_bitblt_io);
-
- switch (size) {
- case 1: return cirrus_linear_bitblt_writeb(s, addr, data);
- case 2: return cirrus_linear_bitblt_writew(s, addr, data);
- case 4: return cirrus_linear_bitblt_writel(s, addr, data);
- default: abort();
- }
-};
-
static MemoryRegionOps cirrus_linear_bitblt_io_ops = {
.read = cirrus_linear_bitblt_read,
.write = cirrus_linear_bitblt_write,
.endianness = DEVICE_LITTLE_ENDIAN,
+ .impl = {
+ .min_access_size = 1,
+ .max_access_size = 1,
+ },
};
#include "exec-memory.h"
--
1.7.5.3
- [Qemu-devel] [RFC v2 00/20] Memory API, Avi Kivity, 2011/06/27
- [Qemu-devel] [RFC v2 08/20] pc: move global memory map out of pc_init1() and into its callers, Avi Kivity, 2011/06/27
- [Qemu-devel] [RFC v2 18/20] cirrus: simplify vga window mmio access functions, Avi Kivity, 2011/06/27
- [Qemu-devel] [RFC v2 14/20] vmsvga: don't remember pci BAR address in callback any more, Avi Kivity, 2011/06/27
- [Qemu-devel] [RFC v2 06/20] pc: grab system_memory, Avi Kivity, 2011/06/27
- [Qemu-devel] [RFC v2 05/20] exec.c: initialize memory map, Avi Kivity, 2011/06/27
- [Qemu-devel] [RFC v2 20/20] cirrus: simplify linear framebuffer access functions, Avi Kivity, 2011/06/27
- [Qemu-devel] [RFC v2 02/20] memory: implement dirty tracking, Avi Kivity, 2011/06/27
- [Qemu-devel] [RFC v2 17/20] cirrus: simplify bitblt BAR access functions,
Avi Kivity <=
- [Qemu-devel] [RFC v2 07/20] pc: convert pc_memory_init() to memory API, Avi Kivity, 2011/06/27
- [Qemu-devel] [RFC v2 12/20] usb-ohci: convert to MemoryRegion, Avi Kivity, 2011/06/27
- [Qemu-devel] [RFC v2 09/20] pci: pass address space to pci bus when created, Avi Kivity, 2011/06/27
- [Qemu-devel] [RFC v2 16/20] cirrus: simplify mmio BAR access functions, Avi Kivity, 2011/06/27
- [Qemu-devel] [RFC v2 19/20] vga: simplify vga window mmio access functions, Avi Kivity, 2011/06/27
- [Qemu-devel] [RFC v2 15/20] vga: convert vga and its derivatives to the memory API, Avi Kivity, 2011/06/27
- [Qemu-devel] [RFC v2 03/20] memory: merge adjacent segments of a single memory region, Avi Kivity, 2011/06/27
- [Qemu-devel] [RFC v2 04/20] Internal interfaces for memory API, Avi Kivity, 2011/06/27