[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC v2 01/20] Hierarchical memory region API
From: |
Jan Kiszka |
Subject: |
Re: [Qemu-devel] [RFC v2 01/20] Hierarchical memory region API |
Date: |
Tue, 28 Jun 2011 12:28:34 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
On 2011-06-28 12:03, Michael S. Tsirkin wrote:
>> +struct MemoryRegion {
>> + /* All fields are private - violators will be prosecuted */
>> + const MemoryRegionOps *ops;
>> + MemoryRegion *parent;
>> + uint64_t size;
>> + target_phys_addr_t addr;
>> + target_phys_addr_t offset;
>> + ram_addr_t ram_addr;
>> + bool has_ram_addr;
>> + MemoryRegion *alias;
>> + target_phys_addr_t alias_offset;
>> + unsigned priority;
>> + bool may_overlap;
>> + QTAILQ_HEAD(subregions, MemoryRegion) subregions;
>> + QTAILQ_ENTRY(MemoryRegion) subregions_link;
>> + QTAILQ_HEAD(coalesced_ranges, CoalescedMemoryRange) coalesced;
>> + const char *name;
>
> I'm never completely sure whether these should be target addresses
> or bus addresses or just uint64_t.
> With pci on a 32 bit system you can stick a 64 bit address
> in a BAR and the result will be that it is never accessed
> from the CPU.
>
Memory regions are not bound to any current or future PCI
specifications. Any fixed bit width would be wrong here, ie. size should
rather be target_phys_addr_t.
Jan
--
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux
- [Qemu-devel] [RFC v2 09/20] pci: pass address space to pci bus when created, (continued)
- [Qemu-devel] [RFC v2 09/20] pci: pass address space to pci bus when created, Avi Kivity, 2011/06/27
- [Qemu-devel] [RFC v2 16/20] cirrus: simplify mmio BAR access functions, Avi Kivity, 2011/06/27
- [Qemu-devel] [RFC v2 19/20] vga: simplify vga window mmio access functions, Avi Kivity, 2011/06/27
- [Qemu-devel] [RFC v2 15/20] vga: convert vga and its derivatives to the memory API, Avi Kivity, 2011/06/27
- [Qemu-devel] [RFC v2 03/20] memory: merge adjacent segments of a single memory region, Avi Kivity, 2011/06/27
- [Qemu-devel] [RFC v2 04/20] Internal interfaces for memory API, Avi Kivity, 2011/06/27
- [Qemu-devel] [RFC v2 01/20] Hierarchical memory region API, Avi Kivity, 2011/06/27
- Re: [Qemu-devel] [RFC v2 01/20] Hierarchical memory region API, Michael S. Tsirkin, 2011/06/28
- Re: [Qemu-devel] [RFC v2 01/20] Hierarchical memory region API,
Jan Kiszka <=
- Re: [Qemu-devel] [RFC v2 01/20] Hierarchical memory region API, Avi Kivity, 2011/06/28
- Re: [Qemu-devel] [RFC v2 01/20] Hierarchical memory region API, Jan Kiszka, 2011/06/28
- Re: [Qemu-devel] [RFC v2 01/20] Hierarchical memory region API, Avi Kivity, 2011/06/28
- Re: [Qemu-devel] [RFC v2 01/20] Hierarchical memory region API, Jan Kiszka, 2011/06/28
- Re: [Qemu-devel] [RFC v2 01/20] Hierarchical memory region API, Avi Kivity, 2011/06/28
- Re: [Qemu-devel] [RFC v2 01/20] Hierarchical memory region API, Peter Maydell, 2011/06/28
- Re: [Qemu-devel] [RFC v2 01/20] Hierarchical memory region API, Avi Kivity, 2011/06/28
- Re: [Qemu-devel] [RFC v2 01/20] Hierarchical memory region API, Olivier Galibert, 2011/06/28
- Re: [Qemu-devel] [RFC v2 01/20] Hierarchical memory region API, Avi Kivity, 2011/06/28
[Qemu-devel] [RFC v2 11/20] sysbus: add MemoryRegion based memory management API, Avi Kivity, 2011/06/27