qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] Make SLIRP Ethernet packets size to 64 bytes mi


From: Stefan Hajnoczi
Subject: Re: [Qemu-devel] [PATCH] Make SLIRP Ethernet packets size to 64 bytes minimuma
Date: Tue, 28 Jun 2011 14:15:44 +0100

On Tue, Jun 28, 2011 at 10:08 AM, Fabien Chouteau <address@hidden> wrote:
> On 28/06/2011 10:34, Stefan Hajnoczi wrote:
>> This patch doesn't hurt but we'd be just as well off without it.
>>
>> Did you do this to fix a bug?  If so, then something else in QEMU
>> needs to be fixed, not slirp.
>
> When Qemu generates bad Ethernet frames, I think it's a bug.
>
> And again, this is the extension of a previous patch. If this patch is not
> valid then we should revert the first, it's also a question of consistency.

IMO the previous patch is not necessary either.

Since there is no net subsystem maintainer who can help decide which
way to go, I'm going to back off from this issue.  Please go ahead.

Stefan



reply via email to

[Prev in Thread] Current Thread [Next in Thread]