[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCHv3] qxl: add io_port_to_string
From: |
Alon Levy |
Subject: |
Re: [Qemu-devel] [PATCHv3] qxl: add io_port_to_string |
Date: |
Wed, 29 Jun 2011 16:25:43 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Wed, Jun 29, 2011 at 03:03:32PM +0200, Gerd Hoffmann wrote:
> Hi,
>
> >- dprint(d, 1, "%s: unexpected port 0x%x in vga mode\n",
> >__FUNCTION__, io_port);
> >+ dprint(d, 1, "%s: unexpected port 0x%x (%s) in vga mode\n",
> >+ __FUNCTION__, io_port, io_port_to_string(io_port));
>
> Is this worth it? Should be a quite rare event ...
well, it's helpful for debugging, so I don't see why not. The extra code is not
that large,
and it's already written :)
>
> cheers,
> Gerd
>
- Re: [Qemu-devel] [PATCHv3] qxl: abort on panic instead of exit, (continued)
[Qemu-devel] [PATCHv3] qxl-logger: add timestamp to command log, Alon Levy, 2011/06/29
[Qemu-devel] [PATCHv3] qxl: update and add debug prints, Alon Levy, 2011/06/29
[Qemu-devel] [PATCHv3] qxl: add dev id to guest prints, Alon Levy, 2011/06/29
[Qemu-devel] [PATCHv3] qxl: add io_port_to_string, Alon Levy, 2011/06/29
[Qemu-devel] [PATCHv3] qxl: update revision to QXL_REVISION_STABLE_V10, Alon Levy, 2011/06/29
[Qemu-devel] [PATCHv3] qxl: add QXL_IO_FLUSH_{SURFACES, RELEASE} for guest S3&S4 support, Alon Levy, 2011/06/29
Re: [Qemu-devel] [PATCHv3] qxl: add QXL_IO_FLUSH_{SURFACES, RELEASE} for guest S3&S4 support, Alon Levy, 2011/06/29
[Qemu-devel] [PATCHv3] qxl: move to UNDEFINED on DESTROY_ALL_SURFACES{, _ASYNC}, Alon Levy, 2011/06/29