|
| From: | Paolo Bonzini |
| Subject: | Re: [Qemu-devel] [PATCH] Add compat eventfd header |
| Date: | Wed, 29 Jun 2011 17:52:51 +0200 |
| User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110428 Fedora/3.1.10-1.fc15 Mnenhy/0.8.3 Thunderbird/3.1.10 |
On 06/29/2011 03:22 PM, Alexander Graf wrote:
Well, you need to make sure that it only gets included on Linux systems and if there's ever some more compatibility wrapping around the syscall (unlikely, but you never know), this could potentially break. Also, who defines SYS_eventfd? What if you're trying to build this code on SLES10 for example, which does not have the syscall and thus doesn't have it defined? Would compilation simply break?
No, he patched configure to use the compat header too, so detection would fail at configure time and eventfd would not be used.
Paolo
| [Prev in Thread] | Current Thread | [Next in Thread] |