Re: [Qemu-devel] [PATCH 2/3] hw/omap_gpio.c: Don't complain about some writes to r/o registers

[Edgar E. Iglesias]

On Wed, Jun 29, 2011 at 07:53:10PM +0100, Peter Maydell wrote:
> Don't complain about some writes to r/o OMAP2 GPIO registers, because the
> kernel will do them anyway.
> 
> Signed-off-by: Peter Maydell <address@hidden>

Hi Peter,

I usually find this kind of logs useful.
Maybe we should turn them into _log_mask(~0, xxx) so they only come out
when -d is enabled?

Cheers


> ---
>  hw/omap_gpio.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/hw/omap_gpio.c b/hw/omap_gpio.c
> index 478f7d9..b53b13b 100644
> --- a/hw/omap_gpio.c
> +++ b/hw/omap_gpio.c
> @@ -385,7 +385,7 @@ static void omap2_gpio_module_write(void *opaque, 
> target_phys_addr_t addr,
>      case 0x00:       /* GPIO_REVISION */
>      case 0x14:       /* GPIO_SYSSTATUS */
>      case 0x38:       /* GPIO_DATAIN */
> -        OMAP_RO_REG(addr);
> +        /* read-only, ignore quietly */
>          break;
>  
>      case 0x10:       /* GPIO_SYSCONFIG */
> @@ -531,7 +531,7 @@ static void omap2_gpio_module_writep(void *opaque, 
> target_phys_addr_t addr,
>      case 0x00:       /* GPIO_REVISION */
>      case 0x14:       /* GPIO_SYSSTATUS */
>      case 0x38:       /* GPIO_DATAIN */
> -        OMAP_RO_REG(addr);
> +        /* read-only, ignore quietly */
>          break;
>  
>      case 0x10:       /* GPIO_SYSCONFIG */
> -- 
> 1.7.1
> 
>