Re: [Qemu-devel] [PATCH 2/3] hw/omap_gpio.c: Don't complain about some writes to r/o registers

[Edgar E. Iglesias]

On Wed, Jun 29, 2011 at 09:39:52PM +0100, Peter Maydell wrote:
> On 29 June 2011 21:07, Edgar E. Iglesias <address@hidden> wrote:
> > On Wed, Jun 29, 2011 at 07:53:10PM +0100, Peter Maydell wrote:
> >> Don't complain about some writes to r/o OMAP2 GPIO registers, because the
> >> kernel will do them anyway.
> >>
> >> Signed-off-by: Peter Maydell <address@hidden>
> >
> > Hi Peter,
> >
> > I usually find this kind of logs useful.
> > Maybe we should turn them into _log_mask(~0, xxx) so they only come out
> > when -d is enabled?
> 
> I think the ideal would be to have all of this kind of message go
> through some consistent path (ie not just printf) so you could
> tell all of qemu "I'm doing OS development, warn about things which
> indicate driver bugs" vs the more common "I'm just a user and I
> don't really care".
> 
> You'd also want to be able to trace the guest program counter
> and to do things like drop into gdb if running with the gdb stub
> enabled.
> 
> In the absence of that kind of infrastructure I tend to default
> to removing this kind of printf or relegating it to DPRINTF.

Yes. I usually find -d exec good enough for this simple errors.
The GDB connection I find useful for more complex hw-errors where
PC location isn't enough to figure out what caused the hw-errror.

I dont feel very strongly about it though.

Cheers