Re: [Qemu-devel] [PATCH V3] Support logging xen-guest console

[Alexander Graf]

On 30.06.2011, at 09:08, Chunyan Liu wrote:

> Add code to support logging xen-domU console, as what xenconsoled does. To
> enable logging, set environment variable XENCONSOLED_TRACE=guest and
> XENCONSOLED_LOGDIR=<specified directory>, log file will be saved in <specified
> directory>.

So far, qemu doesn't rely on environment variables and I don't see a compelling 
reason to introduce us relying on them here. Keep in mind that with Xenner, 
this code is also used without Xen as the host, so it's just like any other 
device driver in qemu.

Please change it to command line options. Also, please run checkpatch.pl on 
your patch before sending it :).


Alex