Re: [Qemu-devel] [PATCH] Make SLIRP Ethernet packets size to 64 bytes minimuma

[Fabien Chouteau]

On 28/06/2011 15:15, Stefan Hajnoczi wrote:
> On Tue, Jun 28, 2011 at 10:08 AM, Fabien Chouteau <address@hidden> wrote:
>> On 28/06/2011 10:34, Stefan Hajnoczi wrote:
>>> This patch doesn't hurt but we'd be just as well off without it.
>>>
>>> Did you do this to fix a bug?  If so, then something else in QEMU
>>> needs to be fixed, not slirp.
>>
>> When Qemu generates bad Ethernet frames, I think it's a bug.
>>
>> And again, this is the extension of a previous patch. If this patch is not
>> valid then we should revert the first, it's also a question of consistency.
> 
> IMO the previous patch is not necessary either.
> 
> Since there is no net subsystem maintainer who can help decide which
> way to go, I'm going to back off from this issue.  Please go ahead.
> 

OK thanks.

Any other comments?

-- 
Fabien Chouteau