[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 08/12] TCG/PPC: use TCG_REG_CALL_STACK instead o
|
From: |
malc |
|
Subject: |
Re: [Qemu-devel] [PATCH 08/12] TCG/PPC: use TCG_REG_CALL_STACK instead of TCG_REG_R1 |
|
Date: |
Sat, 2 Jul 2011 01:06:24 +0400 (MSD) |
|
User-agent: |
Alpine 2.00 (LNX 1167 2008-08-23) |
On Sat, 2 Jul 2011, Blue Swirl wrote:
> On Tue, Jun 28, 2011 at 1:51 AM, malc <address@hidden> wrote:
> > On Sun, 26 Jun 2011, Blue Swirl wrote:
> >
> >> Use TCG_REG_CALL_STACK instead of TCG_REG_R1 etc. for consistency.
> >>
> >
> > This i'd rather avoid.
>
> Why? In addition to the consistency among targets, a magic constant is
> replaced with a symbol which improves the documenting abilities and
> readability of the code.
Makes it harder to read for me personally.
--
mailto:address@hidden