Re: [Qemu-devel] PATCH: fix qemu-mips[el]-static to work with debian squeeze/sid chroot

[Peter Maydell]

On 5 July 2011 11:08, Wesley W. Terpstra <address@hidden> wrote:
> I also recently tried to get a mipsel debian/sid chroot running under my
> amd64/squeeze system. As posted by Lisandro earlier this month, it didn't
> work. ;-) There are several problems, the most glaring of which the attached
> patch fixes.

Thanks for this patch. To get it merged upstream it would be helpful
if you could resubmit it in line with the guidelines at
http://wiki.qemu.org/Contribute/SubmitAPatch
(in particular it needs a Signed-off-by: line, it should be one patch
per bug fix, and it needs to be against current head of qemu git).

In the meantime, some minor initial review comments:

> @@ -1985,6 +1985,20 @@
>       MIPS_SYS(sys_epoll_pwait, 6)
>       MIPS_SYS(sys_ioprio_set, 3)
>       MIPS_SYS(sys_ioprio_get, 2)
> +     MIPS_SYS(sys_utimensat, 4)
> +     MIPS_SYS(sys_ni_syscall, 0) /* signalfd */
> +     MIPS_SYS(sys_ni_syscall, 0) /* timerfd */
> +     MIPS_SYS(sys_eventfd, 1)
> +     MIPS_SYS(sys_fallocate, 4)
> +     MIPS_SYS(sys_ni_syscall, 0) /* timerfd_create */
> +     MIPS_SYS(sys_ni_syscall, 0) /* timerfd_gettime */
> +     MIPS_SYS(sys_ni_syscall, 0) /* timerfd_settime */
> +     MIPS_SYS(sys_ni_syscall, 0) /* signalfd4 */
> +     MIPS_SYS(sys_eventfd2, 2)
> +     MIPS_SYS(sys_epoll_create1, 1)
> +     MIPS_SYS(sys_dup3, 3)
> +     MIPS_SYS(sys_pipe2, 2)
> +     MIPS_SYS(sys_inotify_init1, 1)
>  };

You can drop this bit as there's already a patch in the works
which adds the new syscall numbers:
http://patchwork.ozlabs.org/patch/102241/

(the earlier fix for sigaltstack is still needed).

There are also some bits of your patch which use hardcoded tabs;
these should be spaces. (Yes, existing code is sometimes not
consistent; we tend to convert gradually as we touch code.)

Otherwise I think it looks good.

Thanks again
-- PMM