[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 05/12] xen_console: fix memory leak
From: |
Alexander Graf |
Subject: |
[Qemu-devel] [PATCH 05/12] xen_console: fix memory leak |
Date: |
Tue, 5 Jul 2011 18:51:06 +0200 |
From: Stefano Stabellini <address@hidden>
con_init leaks the string "type", fix it.
Signed-off-by: Stefano Stabellini <address@hidden>
Signed-off-by: Alexander Graf <address@hidden>
---
hw/xen_console.c | 8 ++++++--
1 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/hw/xen_console.c b/hw/xen_console.c
index c6c8163..2d613ee 100644
--- a/hw/xen_console.c
+++ b/hw/xen_console.c
@@ -180,6 +180,7 @@ static int con_init(struct XenDevice *xendev)
{
struct XenConsole *con = container_of(xendev, struct XenConsole, xendev);
char *type, *dom;
+ int ret = 0;
/* setup */
dom = xs_get_domain_path(xenstore, con->xendev.dom);
@@ -189,7 +190,8 @@ static int con_init(struct XenDevice *xendev)
type = xenstore_read_str(con->console, "type");
if (!type || strcmp(type, "ioemu") != 0) {
xen_be_printf(xendev, 1, "not for me (type=%s)\n", type);
- return -1;
+ ret = -1;
+ goto out;
}
if (!serial_hds[con->xendev.dev])
@@ -198,7 +200,9 @@ static int con_init(struct XenDevice *xendev)
else
con->chr = serial_hds[con->xendev.dev];
- return 0;
+out:
+ qemu_free(type);
+ return ret;
}
static int con_connect(struct XenDevice *xendev)
--
1.6.0.2
- [Qemu-devel] [PULL 00/12] Xen patch queue 2011-07-05, Alexander Graf, 2011/07/05
- [Qemu-devel] [PATCH 05/12] xen_console: fix memory leak,
Alexander Graf <=
- [Qemu-devel] [PATCH 09/12] xen_disk: treat "aio" as "raw", Alexander Graf, 2011/07/05
- [Qemu-devel] [PATCH 08/12] qemu_ram_ptr_length: take ram_addr_t as arguments, Alexander Graf, 2011/07/05
- [Qemu-devel] [PATCH 04/12] xen: enable console and disk backend in HVM mode, Alexander Graf, 2011/07/05
- [Qemu-devel] [PATCH 06/12] xen: add vkbd support for PV on HVM guests, Alexander Graf, 2011/07/05
- [Qemu-devel] [PATCH 02/12] xen: Clean up map cache API naming, Alexander Graf, 2011/07/05
- [Qemu-devel] [PATCH 10/12] checkpatch: don't error out on }, { lines, Alexander Graf, 2011/07/05
- [Qemu-devel] [PATCH 07/12] xen_disk: cope with missing xenstore "params" node, Alexander Graf, 2011/07/05
- [Qemu-devel] [PATCH 01/12] xen: Clean up build system, Alexander Graf, 2011/07/05
- [Qemu-devel] [PATCH 11/12] xen_console: support the new extended xenstore protocol, Alexander Graf, 2011/07/05