Re: [Qemu-devel] [SeaBIOS] [PATCH V5 0/9] Add TPM support to SeaBIOS

[Stefan Berger]

On 07/06/2011 06:58 PM, Kevin O'Connor wrote:
> On Wed, Jul 06, 2011 at 12:31:58PM -0400, Stefan Berger wrote:
> > The following set of patches add TPM and Trusted Computing support to SeaBIOS.
> > In particular the patches add:
> >
> > - a TPM driver for the Qemu's TPM TIS emulation (not yet in Qemu git)
> > - ACPI support for the TPM device (SSDT table)
> > - ACPI support for measurement logging (TCPA table)
> > - Support for initialzation of the TPM
> > - Support for the TCG BIOS extensions (1ah handler [ah = 0xbb])
> >    (used by trusted grub; http://trousers.sourceforge.net/grub.html)
> > - Static Root of Trusted for Measurement (SRTM) support
> > - Support for S3 resume (sends command to TPM upon resume)
> > - TPM-specific menu for controlling aspects of the TPM
> > - [An optional test suite for the TIS interface]
> >
> > All implementations necessarily follow specifications.
> ...
>
> Thanks Stefan.
>
> Where does this stand with respect to QEmu integration?
Qemu integration is at least 'working' for me - it's just lacking 
review/attention on the Qemu mailing list.

> BTW, I don't think patch 7 or 9 really make sense to integrate in the
> official version of SeaBIOS.  Also, in patch 8, I'd prefer to see all
> new fw_cfg entries use the "romfile" mechanism.
Patch 7 is the menu. This patch is needed in 'some form' since in some 
cases, like after giving up ownership of the TPM, the TPM becomes 
disabled and deactivated and one has to interact with the BIOS to 
activate and enable it again. Other scenarios include someone who has 
forgotten the owner password for the TPM and now has to go through the 
BIOS to give up ownership of it -- that's the only way one can do this then.

I'll have a look at the 'romfile' mechanism for patch 8.

I only post patch 9 for someone who is interested to be able to run the 
tests. Since the 128kb are slowly filling up, it's not going to be 
compilable with it for much longer and I don't expect it to go into the 
repo.

Thanks for the feedback.

   Stefan
> -Kevin