Re: [Qemu-devel] [PATCH] Error: Fix build when qemu-common.h is not included

[Stefan Weil]

Am 07.07.2011 18:17, schrieb Michael Roth:
> On 07/07/2011 11:02 AM, Luiz Capitulino wrote:
> > Commit e4ea5e2d0e0e4c5188ab45b66f3195062ae059dc added the use of
> > the macro GCC_FMT_ATTR to error.h, however qemu-common.h is not
> > included by error.h
> >
> > This will cause a build error when files including error.h
> > don't include qemu-common.h. Not an issue today because the only
> > file including it is json-parser.h and it does include
> > qemu-common.h, but let's fix it.
> >
> > Signed-off-by: Luiz Capitulino<address@hidden>
> > ---
> >   error.h |    2 +-
> >   1 files changed, 1 insertions(+), 1 deletions(-)

The same argument could be applied to more QEMU *.h files
which also work only after qemu-common.h. Otherwise, including
qemu-common.h in *.c files would rarely be needed.

As far as I remember, the *.h files used to be more self-contained
some years ago, but then the strategy changed and central files
like qemu-common.h were introduced.

I personally prefer self-contained include files like error.h
(before my patch and after your patch), but I'm afraid that
the QEMU way is different.

Cheers,
Stefan W.