[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] qxl: async I/O
From: |
Alon Levy |
Subject: |
Re: [Qemu-devel] [PATCH v2] qxl: async I/O |
Date: |
Fri, 8 Jul 2011 10:12:01 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Fri, Jul 08, 2011 at 09:17:50AM +0200, Gerd Hoffmann wrote:
> >+void qxl_spice_update_area_async(PCIQXLDevice *qxl, uint32_t surface_id,
> >+ struct QXLRect *area, struct QXLRect
> >*dirty_rects,
> >+ uint32_t num_dirty_rects, uint32_t
> >clear_dirty_region,
> >+ int async)
> >+{
> >+ if (async) {
> >+ qxl->ssd.worker->update_area_async(qxl->ssd.worker, surface_id,
> >area, dirty_rects,
> >+ num_dirty_rects, clear_dirty_region, 0);
>
> Fails to build with older libspice.
btw, I'm looking at "#if.*MINOR" code like
#if SPICE_INTERFACE_CORE_MINOR >= 3
(ui/spice-core.c)
Shouldn't that be checking the MAJOR as well?
[snip]
- Re: [Qemu-devel] [PATCH v2] qxl: bump pci rev, (continued)
- [Qemu-devel] [PATCH v2] qxl: only disallow specific io's in vga mode, Alon Levy, 2011/07/07
- [Qemu-devel] [PATCH v2] qxl: make qxl_guest_bug take variable arguments, Alon Levy, 2011/07/07
- [Qemu-devel] [PATCH v2] qxl: add QXL_IO_FLUSH_{SURFACES, RELEASE} for guest S3&S4 support, Alon Levy, 2011/07/07
- [Qemu-devel] [PATCH v2] qxl: error handling fixes and cleanups., Alon Levy, 2011/07/07
- [Qemu-devel] [PATCH v2] qxl: add io_port_to_string, Alon Levy, 2011/07/07
- [Qemu-devel] [PATCH v2] qxl: async I/O, Alon Levy, 2011/07/07
[Qemu-devel] [PATCH v2] qxl: remove qxl_destroy_primary(), Alon Levy, 2011/07/07
[Qemu-devel] [PATCH v2] spice/qxl: move worker wrappers, Alon Levy, 2011/07/07
[Qemu-devel] [PATCH v2] qxl: fix surface tracking & locking, Alon Levy, 2011/07/07
[Qemu-devel] [PATCH v2] spice: add qemu_spice_display_init_common, Alon Levy, 2011/07/07
[Qemu-devel] [PATCH v2] spice: add worker wrapper functions., Alon Levy, 2011/07/07