Re: [Qemu-devel] [PATCH v2] Fix signal handling when io-thread is disabled

[Alexandre Raymond]

ping?

On Tue, Jun 14, 2011 at 12:47 PM, Jan Kiszka <address@hidden> wrote:
> On 2011-06-14 16:05, Alexandre Raymond wrote:
>> Changes since v1:
>> - take pthread_sigmask() out of the ifdef as it is now common
>> to both parts.
>>
>> This fix effectively blocks, in the main thread, the signals handled
>> by signalfd or the compatibility signal thread.
>>
>> This way, such signals are received synchronously in the main thread
>> through sigfd_handler() instead of triggering the signal handler
>> directly, asynchronously.
>>
>> Signed-off-by: Alexandre Raymond <address@hidden>
>> ---
>>  cpus.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/cpus.c b/cpus.c
>> index 4ab76f0..18a1522 100644
>> --- a/cpus.c
>> +++ b/cpus.c
>> @@ -399,7 +399,6 @@ static int qemu_signal_init(void)
>>      sigaddset(&set, SIGALRM);
>>      sigaddset(&set, SIG_IPI);
>>      sigaddset(&set, SIGBUS);
>> -    pthread_sigmask(SIG_BLOCK, &set, NULL);
>>  #else
>>      sigemptyset(&set);
>>      sigaddset(&set, SIGBUS);
>> @@ -412,6 +411,7 @@ static int qemu_signal_init(void)
>>          sigaddset(&set, SIGALRM);
>>      }
>>  #endif
>> +    pthread_sigmask(SIG_BLOCK, &set, NULL);
>>
>>      sigfd = qemu_signalfd(&set);
>>      if (sigfd == -1) {
>
> Acked-by: Jan Kiszka <address@hidden>
>
> Thanks,
> Jan
>
> --
> Siemens AG, Corporate Technology, CT T DE IT 1
> Corporate Competence Center Embedded Linux
>