qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 2/2] qemu-io: Fix if scoping bug


From: Kevin Wolf
Subject: Re: [Qemu-devel] [PATCH 2/2] qemu-io: Fix if scoping bug
Date: Mon, 11 Jul 2011 15:18:02 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110428 Fedora/3.1.10-1.fc15 Thunderbird/3.1.10

Am 11.07.2011 11:47, schrieb Stefan Hajnoczi:
> On Mon, Jul 11, 2011 at 6:25 AM, Devin Nakamura <address@hidden> wrote:
>> diff --git a/qemu-io.c b/qemu-io.c
>> index e484f40..85cfe27 100644
>> --- a/qemu-io.c
>> +++ b/qemu-io.c
>> @@ -449,7 +449,7 @@ static int read_f(int argc, char **argv)
>>         return 0;
>>     }
>>
>> -    if (!pflag)
>> +    if (!pflag) {
>>         if (offset & 0x1ff) {
>>             printf("offset %" PRId64 " is not sector aligned\n",
>>                    offset);
> 
> Wait, this is not enough.  The indentation and curlies are so broken
> here :).  The if (offset & 0x1ff) statement needs a closing curly.

It's actually there, patch 1 already contains it. Breaks bisectability,
of course.

Kevin



reply via email to

[Prev in Thread] Current Thread [Next in Thread]