Re: [Qemu-devel] [PATCH 2/2] qemu-io: Fix if scoping bug

[Stefan Hajnoczi]

On Mon, Jul 11, 2011 at 2:18 PM, Kevin Wolf <address@hidden> wrote:
> Am 11.07.2011 11:47, schrieb Stefan Hajnoczi:
>> On Mon, Jul 11, 2011 at 6:25 AM, Devin Nakamura <address@hidden> wrote:
>>> diff --git a/qemu-io.c b/qemu-io.c
>>> index e484f40..85cfe27 100644
>>> --- a/qemu-io.c
>>> +++ b/qemu-io.c
>>> @@ -449,7 +449,7 @@ static int read_f(int argc, char **argv)
>>>         return 0;
>>>     }
>>>
>>> -    if (!pflag)
>>> +    if (!pflag) {
>>>         if (offset & 0x1ff) {
>>>             printf("offset %" PRId64 " is not sector aligned\n",
>>>                    offset);
>>
>> Wait, this is not enough.  The indentation and curlies are so broken
>> here :).  The if (offset & 0x1ff) statement needs a closing curly.
>
> It's actually there, patch 1 already contains it. Breaks bisectability,
> of course.

Devin,
Please make patch 1 only fix formatting and move any other changes
into later patches.

Stefan