[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCHv3] qxl: add QXL_IO_FLUSH_{SURFACES, RELEASE} for gue
From: |
Alon Levy |
Subject: |
[Qemu-devel] [PATCHv3] qxl: add QXL_IO_FLUSH_{SURFACES, RELEASE} for guest S3&S4 support |
Date: |
Tue, 12 Jul 2011 16:55:32 +0300 |
Add two new IOs.
QXL_IO_FLUSH_SURFACES - equivalent to update area for all surfaces, used
to reduce vmexits from NumSurfaces to 1 on guest S3, S4 and resolution change
(windows
driver implementation is such that this is done on each of those occasions).
QXL_IO_FLUSH_RELEASE - used to ensure anything on last_release is put on the
release ring
for the client to free.
Cc: Yonit Halperin <address@hidden>
---
hw/qxl.c | 32 ++++++++++++++++++++++++++++++++
1 files changed, 32 insertions(+), 0 deletions(-)
diff --git a/hw/qxl.c b/hw/qxl.c
index 1d6acce..a9cc1a3 100644
--- a/hw/qxl.c
+++ b/hw/qxl.c
@@ -181,6 +181,13 @@ static void qxl_spice_destroy_surface_wait(PCIQXLDevice
*qxl, uint32_t id,
}
}
+#if SPICE_INTERFACE_QXL_MINOR >= 1
+static void qxl_spice_flush_surfaces_async(PCIQXLDevice *qxl)
+{
+ qxl->ssd.worker->flush_surfaces_async(qxl->ssd.worker, 0);
+}
+#endif
+
void qxl_spice_loadvm_commands(PCIQXLDevice *qxl, struct QXLCommandExt *ext,
uint32_t count)
{
@@ -1195,6 +1202,7 @@ static void ioport_write(void *opaque, uint32_t addr,
uint32_t val)
case QXL_IO_DESTROY_PRIMARY_ASYNC:
case QXL_IO_DESTROY_SURFACE_ASYNC:
case QXL_IO_DESTROY_ALL_SURFACES_ASYNC:
+ case QXL_IO_FLUSH_SURFACES_ASYNC:
#if SPICE_INTERFACE_QXL_MINOR < 1
fprintf(stderr, "qxl: error: async not supported by libspice but guest
driver used it\n");
return;
@@ -1322,6 +1330,30 @@ static void ioport_write(void *opaque, uint32_t addr,
uint32_t val)
}
qxl_spice_destroy_surface_wait(d, val, async);
break;
+ case QXL_IO_FLUSH_RELEASE: {
+ QXLReleaseRing *ring = &d->ram->release_ring;
+ if (ring->prod - ring->cons + 1 == ring->num_items) {
+ fprintf(stderr,
+ "ERROR: no flush, full release ring [p%d,%dc]\n",
+ ring->prod, ring->cons);
+ }
+ qxl_push_free_res(d, 1 /* flush */);
+ dprint(d, 1, "QXL_IO_FLUSH_RELEASE exit (%s, s#=%d, res#=%d,%p)\n",
+ qxl_mode_to_string(d->mode), d->guest_surfaces.count,
+ d->num_free_res, d->last_release);
+ break;
+ }
+ case QXL_IO_FLUSH_SURFACES_ASYNC:
+#if SPICE_INTERFACE_QXL_MINOR >= 1
+ dprint(d, 1, "QXL_IO_FLUSH_SURFACES_ASYNC (%d) (%s, s#=%d, res#=%d)\n",
+ val, qxl_mode_to_string(d->mode), d->guest_surfaces.count,
+ d->num_free_res);
+ qxl_spice_flush_surfaces_async(d);
+#else
+ dprint(d, 1, "QXL_IO_FLUSH_SURFACES_ASYNC (%d) ignored, too old spice
server\n",
+ val);
+#endif
+ break;
case QXL_IO_DESTROY_ALL_SURFACES_ASYNC:
case QXL_IO_DESTROY_ALL_SURFACES:
d->mode = QXL_MODE_UNDEFINED;
--
1.7.6
- [Qemu-devel] [PATCHv3] qxl: async io support using new spice api, (continued)
- [Qemu-devel] [PATCHv3] qxl: async io support using new spice api, Alon Levy, 2011/07/12
- [Qemu-devel] [PATCHv3] qxl: use QXL_REVISION_*, Alon Levy, 2011/07/12
- [Qemu-devel] [PATCHv3] qxl-render: qxl_render_update: nop if \!ssd.running, Alon Levy, 2011/07/12
- [Qemu-devel] [PATCHv3] qxl: qxl_send_events: ignore if stopped (instead of abort), Alon Levy, 2011/07/12
- [Qemu-devel] [PATCHv3] qxl-render: use update_area_async and update_area_complete, Alon Levy, 2011/07/12
- [Qemu-devel] [PATCHv3] qxl: only disallow specific io's in vga mode, Alon Levy, 2011/07/12
- [Qemu-devel] [PATCHv3] qxl: add QXL_IO_FLUSH_{SURFACES, RELEASE} for guest S3&S4 support,
Alon Levy <=
- Re: [Qemu-devel] [PATCHv3] async + suspend reworked, Gerd Hoffmann, 2011/07/13
- Re: [Qemu-devel] [PATCHv3] async + suspend reworked, Gerd Hoffmann, 2011/07/13