Re: [Qemu-devel] [PATCHv3] qxl-render/qxl: split out qxl_save_ppm

[Luiz Capitulino]

On Wed, 13 Jul 2011 13:46:50 +0200
Gerd Hoffmann <address@hidden> wrote:

>    Hi,
> 
> > I'd rather try the MONITOR_CMD_ASYNC thing then the cond variable, it's 
> > becoming pretty
> > ugly. Also I guess what Daniel described is possible, but it changes the 
> > usage of screendump
> > even more. Is turning do_screen_dump to async viable? I think I'll work on 
> > it.
> 
> Daniel's suggestion is a nice option which goes on top ;)

Some months ago it was suggested that we returned the screenshot as a base64
string. But this might have issues if the screenshot is/becomes too large,
as we're imposing some limits on the json token size (I think it's 64MB today).

Daniel's idea seems to be a good one though.

> 
> The filename-based screendump has to continue working for backward 
> compatibility reasons.
> 
> cheers,
>    Gerd
>