Re: [Qemu-devel] [PATCH] Introduce "info migrate-times" monitor command

[Paolo Bonzini]

On 07/13/2011 03:06 PM, Michal Novotny wrote:
> +uint64_t time_get(const char *name, int stage);
> +void time_set(const char *name, int stage, uint64_t tv);
> +void time_add(const char *name, int stage, uint64_t tv);
> +void time_add2(const char *name, int stage, uint64_t time1, uint64_t time2);
> +uint64_t save_total_time(void);

Please inline all these instead of adding new functions.

> +
>   /* SLIRP */
>   void do_info_slirp(Monitor *mon);
>
> diff --git a/vl.c b/vl.c
> index fcd7395..340cbe3 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -229,6 +229,12 @@ unsigned int nb_prom_envs = 0;
>   const char *prom_envs[MAX_PROM_ENVS];
>   int boot_menu;
>
> +/* Times */
> +static uint64_t time_save_total[3];
> +static uint64_t time_save_disk[3];
> +static uint64_t time_save_ram[3];
> +static uint64_t time_save_wait_input;

Please move these to savevm.c instead.  The implementation of the 
monitor command can also go to savevm.c.

Thanks,

Paolo