|
From: | Gerd Hoffmann |
Subject: | Re: [Qemu-devel] [PATCHv5 12/12] qxl: use QXL_REVISION_* |
Date: | Fri, 15 Jul 2011 10:23:39 +0200 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.18) Gecko/20110617 Red Hat/3.1.11-2.el6_1 Thunderbird/3.1.11 |
Hi,
+#if SPICE_INTERFACE_QXL_MINOR>= 1 + qemu_mutex_init(&qxl->async_lock); + qxl->current_async = QXL_UNDEFINED_IO; +#endif
That surely belongs into another patch ...
+ case QXL_REVISION_STABLE_V04: /* spice 0.4 -- qxl-1 */ + case QXL_REVISION_STABLE_V06: /* spice 0.6 -- qxl-2 */
I think we should just not use these defines for now.In a year or so when the new bits are in widespread use we can raise the minimum required spice-server+spice-protocol versions, cleanup the ifdef mess and also use QXL_REVISION_STABLE_V04.
cheers, Gerd
[Prev in Thread] | Current Thread | [Next in Thread] |