Re: [Qemu-devel] [PATCH 05/21] scsi: Add 'hba_private' to SCSIRequest

[David Gibson]

On Tue, Jul 19, 2011 at 11:20:22PM +1000, Benjamin Herrenschmidt wrote:
> On Tue, 2011-07-19 at 07:43 -0500, Anthony Liguori wrote:
> > 
> > This breaks the build:
> > 
> > make[1]: Nothing to be done for `all'.
> >    CC    ppc64-softmmu/spapr_vscsi.o
> > /home/anthony/git/qemu/hw/spapr_vscsi.c: In function 
> > ‘vscsi_command_complete’:
> > /home/anthony/git/qemu/hw/spapr_vscsi.c:535:34: error: ‘s’ undeclared 
> > (first use in this function)
> > /home/anthony/git/qemu/hw/spapr_vscsi.c:535:34: note: each undeclared 
> > identifier is reported only once for each function it appears in
> > 
> > This file is only built when libfdt is installed which is probably
> > why 
> > you didn't catch it.
> > 
> > Ben/David, is there a way we can still build most of this stuff
> > without 
> > libfdt?  libfdt is still not commonly packaged by some distros.
> 
> That would be hard ... the DT stuff is pretty deeply involved. Might be
> easier to try to fix the distro :-)

Actually, I think what we should do is embed libfdt into qemu.  It's
small, it will remove a bunch of irritating config dependencies, and
it's designed to embeddable in this way.

-- 
David Gibson                    | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
                                | _way_ _around_!
http://www.ozlabs.org/~dgibson