Re: [Qemu-devel] [RFC v4 00/58] Memory API

[Jan Kiszka]

On 2011-07-20 13:57, Avi Kivity wrote:
> On 07/20/2011 02:43 PM, Jan Kiszka wrote:
>> On 2011-07-20 10:13, Avi Kivity wrote:
>>>  On 07/19/2011 08:30 PM, Jan Kiszka wrote:
>>>>>   Rebasing is already not so fun for me with 78 patches and counting.
>>>>>   Let's drop yours and focus of getting mine in shape, since it's a 
>>>>> superset.
>>>>
>>>>  The patches series are widely orthogonal except for both killing the
>>>>  obsolete start/stop logging logic.
>>>>
>>>>  But I don't mind rebasing over yours - if something is finally merged at
>>>>  all.
>>>
>>>  If you post patches I'll incorporate them in my patchset.  They're
>>>  available in qemu-kvm.git branch memory-region.
>>
>> Is that branch up-to-date? It spits out tons of debug messages, making
>> it unusable for any test.
>>
> 
> I usually redirect them away.
> 
> I'll move the two patches on top, so it's easy to have git drop them.

Something around dirty logging is still seriously borken: when I boot
with standard or cirrus vga, the screen is not properly updated in
logged modes.

I bet the reason is lacking semantics of
cpu_register_physical_memory_log(..., true), ie. the chance to register
a memory region with logging enabled. We need to explicitly enable it
now via memory_region_set_log, right? Is there any ordering issue to
expect, ie. when can I first call memory_region_set_log (as it issues
the start/stop client callbacks)?

Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux