Re: [Qemu-devel] [PATCHv2] target-arm: support for ARM1176JZF-s cores

[Peter Maydell]

On 20 July 2011 16:36, Jamie Iles <address@hidden> wrote:
> On Wed, Jul 20, 2011 at 03:35:19PM +0100, Peter Maydell wrote:
>> On 19 July 2011 13:32, Jamie Iles <address@hidden> wrote:
>> > Add support for v6K ARM1176JZF-S.  This core includes the VA<->PA
>> > translation capability and security extensions.
>>
>> > +static uint32_t arm1176_cp15_c0_c1[8] =
>> > +{ 0x111, 0x11, 0x33, 0x01130003, 0x01130003, 0x10030302, 0x01222100, 0 };
>>
>> This seems to be the wrong value for the AUXFR0 (0,c0,c1,3 : fourth item
>> in this list). The 1176JZF-S TRM says its value is 0x0, not 0x01130003
>> (which I think you've miscopied from the 0,c0,c1,4 MMFR0 entry).
>
> Ahh, yes.  Thanks for that, a good spot.

Thanks for the quick patch refresh. This version is
Reviewed-by: Peter Maydell <address@hidden>

> 8<------

Incidentally, this is a bit of an unfortunate format for patches, as it
doesn't apply with the usual "git am filename". Even if you add "-c" git
still puts these headers:

> From af92ff0cd28077ff187f2ac1d952f71297b7d026 Mon Sep 17 00:00:00 2001
> From: Jamie Iles <address@hidden>
> Date: Thu, 23 Jun 2011 11:37:19 +0100
> Subject: [PATCHv3] target-arm: support for ARM1176JZF-s cores

into the commit log.

-- PMM