qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] Guest agent does not build on OpenBSD


From: Anthony Liguori
Subject: Re: [Qemu-devel] Guest agent does not build on OpenBSD
Date: Fri, 22 Jul 2011 14:05:48 -0500
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110516 Lightning/1.0b2 Thunderbird/3.1.10

On 07/22/2011 02:00 PM, Brad wrote:
On 22/07/11 2:28 PM, Blue Swirl wrote:
I get these errors on OpenBSD:
CC qga/guest-agent-commands.o
/src/qemu/qga/guest-agent-commands.c:14:20: warning: mntent.h: No such
file or directory
/src/qemu/qga/guest-agent-commands.c:17:22: warning: linux/fs.h: No
such file or directory
In file included from /src/qemu/qga/guest-agent-commands.c:19:
qapi-generated/qga-qmp-commands.h:36:7: warning: no newline at end of
file
/src/qemu/qga/guest-agent-commands.c: In function
'guest_fsfreeze_build_mount_list':
/src/qemu/qga/guest-agent-commands.c:344: error: 'MOUNTED' undeclared
(first use in this function)
/src/qemu/qga/guest-agent-commands.c:344: error: (Each undeclared
identifier is reported only once
/src/qemu/qga/guest-agent-commands.c:344: error: for each function it
appears in.)
/src/qemu/qga/guest-agent-commands.c:354: warning: implicit
declaration of function 'setmntent'
/src/qemu/qga/guest-agent-commands.c:354: warning: nested extern
declaration of 'setmntent'
/src/qemu/qga/guest-agent-commands.c:354: warning: assignment makes
pointer from integer without a cast
/src/qemu/qga/guest-agent-commands.c:360: warning: implicit
declaration of function 'getmntent'
/src/qemu/qga/guest-agent-commands.c:360: warning: nested extern
declaration of 'getmntent'
/src/qemu/qga/guest-agent-commands.c:360: warning: assignment makes
pointer from integer without a cast
/src/qemu/qga/guest-agent-commands.c:367: error: dereferencing pointer
to incomplete type
/src/qemu/qga/guest-agent-commands.c:368: error: dereferencing pointer
to incomplete type
/src/qemu/qga/guest-agent-commands.c:369: error: dereferencing pointer
to incomplete type
/src/qemu/qga/guest-agent-commands.c:374: error: dereferencing pointer
to incomplete type
/src/qemu/qga/guest-agent-commands.c:375: error: dereferencing pointer
to incomplete type
/src/qemu/qga/guest-agent-commands.c:380: warning: implicit
declaration of function 'endmntent'
/src/qemu/qga/guest-agent-commands.c:380: warning: nested extern
declaration of 'endmntent'
/src/qemu/qga/guest-agent-commands.c: In function
'qmp_guest_fsfreeze_freeze':
/src/qemu/qga/guest-agent-commands.c:436: error: 'FIFREEZE' undeclared
(first use in this function)
/src/qemu/qga/guest-agent-commands.c: In function
'qmp_guest_fsfreeze_thaw':
/src/qemu/qga/guest-agent-commands.c:474: error: 'FITHAW' undeclared
(first use in this function)

Maybe guest agent should be only built on supported hosts.

*sigh* This was some pretty sloppy work that was commited with very
little testing. The QAPI stuff that was commited also needs Python
to build and no appropriate checks were added to the configure script
to check for its presence and to allow the person building to point
to appropriate Python binary instead of a hardcoded binary name in the
Makefile.


Patches are certainly welcome.

Python in taken from path so you can certainly overload it.

Regards,

Anthony Liguori




reply via email to

[Prev in Thread] Current Thread [Next in Thread]