[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RESEND][PATCH v3] Generalize -machine command line opt
From: |
Jan Kiszka |
Subject: |
Re: [Qemu-devel] [RESEND][PATCH v3] Generalize -machine command line option |
Date: |
Mon, 25 Jul 2011 12:33:01 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
On 2011-07-25 11:41, Richard W.M. Jones wrote:
> On Sat, Jul 23, 2011 at 12:38:37PM +0200, Jan Kiszka wrote:
>> From: Jan Kiszka <address@hidden>
>>
>> -machine somehow suggests that it selects the machine, but it doesn't.
>> Fix that before this command is set in stone.
>>
>> Actually, -machine should supersede -M and allow to introduce arbitrary
>> per-machine options to the command line. That will change the internal
>> realization again, but we will be able to keep the user interface
>> stable.
>
> This breaks libguestfs which was doing:
>
> qemu -machine accel=kvm:tcg ...
>
> We are not passing any -M option at all. We don't particularly care
> about the machine type since we're not that performance sensitive and
> we don't need to serialize the machine state.
>
> I have checked, and this works:
>
> qemu -machine pc,accel=kvm:tcg ...
>
> "pc" is the default, right? What about for other architectures?
Yes, pc is the right default. Other arch have other defaults.
>
> Please add qemu capabilities, so we can reasonably detect what an
> unknown qemu binary supports and so we don't need to do endless
> parsing of the -help output and guesswork.
This syntax was not yet released (but will be with 0.15, so I was
pushing this). Therefore, nothing was "officially" broken by this patch.
I'm sorry if you may have released any libguestfs with the transient
syntax, but my patches were waiting quite a while for being merged since
the introduction of -machine.
Jan
--
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux
- [Qemu-devel] [RESEND][PATCH v3] Generalize -machine command line option, Jan Kiszka, 2011/07/23
- [Qemu-devel] [RESEND][PATCH 2/2] Deprecate -M command line options, Jan Kiszka, 2011/07/23
- Re: [Qemu-devel] [RESEND][PATCH v3] Generalize -machine command line option, Anthony Liguori, 2011/07/23
- Re: [Qemu-devel] [RESEND][PATCH v3] Generalize -machine command line option, Richard W.M. Jones, 2011/07/25
- Re: [Qemu-devel] [RESEND][PATCH v3] Generalize -machine command line option,
Jan Kiszka <=
- Re: [Qemu-devel] [RESEND][PATCH v3] Generalize -machine command line option, Richard W.M. Jones, 2011/07/25
- Re: [Qemu-devel] [RESEND][PATCH v3] Generalize -machine command line option, Jan Kiszka, 2011/07/25
- Re: [Qemu-devel] [RESEND][PATCH v3] Generalize -machine command line option, Markus Armbruster, 2011/07/25
- Re: [Qemu-devel] [RESEND][PATCH v3] Generalize -machine command line option, Jan Kiszka, 2011/07/25
- [Qemu-devel] [PATCH] Allow to leave type on default in -machine, Jan Kiszka, 2011/07/25
- Re: [Qemu-devel] [PATCH] Allow to leave type on default in -machine, Richard W.M. Jones, 2011/07/25
- Re: [Qemu-devel] [PATCH] Allow to leave type on default in -machine, Alexander Graf, 2011/07/25
- Re: [Qemu-devel] [PATCH] Allow to leave type on default in -machine, Anthony Liguori, 2011/07/29
- Re: [Qemu-devel] [RESEND][PATCH v3] Generalize -machine command line option, Anthony Liguori, 2011/07/25
- Re: [Qemu-devel] [RESEND][PATCH v3] Generalize -machine command line option, Peter Maydell, 2011/07/25