[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 02/55] block: Reset device model callbacks on de
|
From: |
Christoph Hellwig |
|
Subject: |
Re: [Qemu-devel] [PATCH 02/55] block: Reset device model callbacks on detach |
|
Date: |
Mon, 25 Jul 2011 14:27:47 +0200 |
|
User-agent: |
Mutt/1.5.17 (2007-11-01) |
On Wed, Jul 20, 2011 at 06:23:36PM +0200, Markus Armbruster wrote:
> BlockDriverState members change_cb and change_opaque are initially
> null. The device model may set them, with bdrv_set_change_cb(). If
> the device model gets detached (hot unplug), they're left dangling.
> Only safe because device hot unplug automatically destroys the
> BlockDriverState. But that's a questionable feature, best not to rely
> on it.
Looks good,
Reviewed-by: Christoph Hellwig <address@hidden>
- Re: [Qemu-devel] [PATCH 18/55] scsi-disk: Reject CD-specific SCSI commands to disks, (continued)
[Qemu-devel] [PATCH 24/55] ide/atapi: Track tray locked state, Markus Armbruster, 2011/07/20
[Qemu-devel] [PATCH 17/55] ide/atapi: Switch from BlockDriverState's tray_open to own, Markus Armbruster, 2011/07/20
[Qemu-devel] [PATCH 19/55] scsi-disk: Factor out scsi_disk_emulate_start_stop(), Markus Armbruster, 2011/07/20
[Qemu-devel] [PATCH 02/55] block: Reset device model callbacks on detach, Markus Armbruster, 2011/07/20
- Re: [Qemu-devel] [PATCH 02/55] block: Reset device model callbacks on detach,
Christoph Hellwig <=
[Qemu-devel] [PATCH 36/55] ide: Give vmstate structs internal linkage where possible, Markus Armbruster, 2011/07/20
[Qemu-devel] [PATCH 20/55] scsi-disk: Track tray open/close state, Markus Armbruster, 2011/07/20
[Qemu-devel] [PATCH 49/55] block: Declare qemu_blockalign() in block.h, not block_int.h, Markus Armbruster, 2011/07/20
[Qemu-devel] [PATCH 50/55] block: New bdrv_set_buffer_alignment(), Markus Armbruster, 2011/07/20