Re: [Qemu-devel] [Qemu-trivial] [PATCH] Makefile: fix out-of-tree builds

[Stefan Hajnoczi]

On Mon, Jul 25, 2011 at 1:16 PM, Michael Roth <address@hidden> wrote:
> On 07/25/2011 05:15 AM, Stefan Hajnoczi wrote:
>>
>> On Thu, Jul 21, 2011 at 5:41 AM, Alexandre Raymond<address@hidden>
>>  wrote:
>>>
>>> This patch fixes a minor bugs which prevented QEMU from being built
>>> out of tree.
>>>
>>> Signed-off-by: Alexandre Raymond<address@hidden>
>>> ---
>>>  Makefile |    2 +-
>>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> I don't normally use --source-path but it still seems broken to me
>> after applying your patch?
>>
>> $ cd /tmp; mkdir out; cd out
>> $ ~/qemu/configure --source-path=$HOME/qemu
>> $ make
>>   GEN   config-all-devices.mak
>> cat: i386-softmmu/config-devices.mak: No such file or directory
>> cat: x86_64-softmmu/config-devices.mak: No such file or directory
>> cat: alpha-softmmu/config-devices.mak: No such file or directory
>>
>> Stefan
>>
>
> Works okay for me with and without the patch if I do a `make distclean` in
> $HOME/qemu beforehand.
>
> Not sure what the trigger is for the breakage Alexandre is trying to
> address.

You are right that make distclean in the source directory solves the issue.

Intuitively I expect ./configure to re-wire things, make distclean
should not be necessary.

Alexandre: Can you describe the case where you hit a build issue in more detail?

Stefan