qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [RFC][PATCH 0/21] QEMU Object Model


From: Anthony Liguori
Subject: Re: [Qemu-devel] [RFC][PATCH 0/21] QEMU Object Model
Date: Mon, 25 Jul 2011 08:10:22 -0500
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110516 Lightning/1.0b2 Thunderbird/3.1.10

On 07/25/2011 08:08 AM, Kevin Wolf wrote:
Am 25.07.2011 14:45, schrieb Anthony Liguori:
Okay, if it isn't possible with reasonable effort, I guess we'll have to
bite the bullet and give it a very careful manual review immediately
before the merge.

By the way, I see that you create new directories. You probably have an
idea of what the directory structure will look like after the whole
conversion is completed. Can you share this idea with us?

Just the logic extension of what we have already:

block/
chrdrv/
net/
qom/
qapi/
devices/
  \  pc/
   | pci/
   | scsi/
   | etc.

I think Foo and FooClass is better because Foo is the most common usage
of the type and it's less characters to type.

Maybe. But then, CharDriver is a really bad names for an instance. There
is only one driver, which made it a good name for the class until now.
Maybe CharBackend and CharBackendClass (or CharBackendDriver) would be a
more sensible replacement that follows your pattern.

Good suggestion. I've been thinking that there's like to be a need for a generic Backend base class too so that would work well from a naming convention perspective.

Regards,

Anthony Liguori


Kevin





reply via email to

[Prev in Thread] Current Thread [Next in Thread]