Re: [Qemu-devel] [PATCH 0/7] balloon: cleanups, fix segfault

[Markus Armbruster]

Amit Shah <address@hidden> writes:

> 'balloon 0' in the monitor causes a segfault.  This happens because
> the function that handles change in balloon values is also tasked with
> handling stats retrieval from the guest, and it does the retrieval
> when the balloon target is '0'.
>
> Silly API, replace it.  Also do a few cleanups along the way.

Silly indeed.

Consider explaining the crash in 5/7's commit message.

Reviewed-by: Markus Armbruster <address@hidden>