qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] Introduce QEMU_NEW()


From: Avi Kivity
Subject: Re: [Qemu-devel] [PATCH] Introduce QEMU_NEW()
Date: Mon, 25 Jul 2011 18:24:36 +0300
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.18) Gecko/20110621 Fedora/3.1.11-1.fc15 Thunderbird/3.1.11

On 07/25/2011 06:21 PM, Jes Sorensen wrote:
On 07/25/11 17:20, Avi Kivity wrote:
>  On 07/25/2011 06:17 PM, Jes Sorensen wrote:
>>  Using the commands consistently does have an impact, and at least with
>>  qemu_malloc() it is obvious what they are and how they behave. The
>>  proposed macros on the other hand requires everybody to go look up the
>>  macro to find out what it is trying to do.
>
>  That's true for every single function and macro that qemu defines.
>

Of course, and every time it adds complexity for reading it. In this
particular case it seems to simply make the code worse for no gain.

I guess type safety doesn't matter to you.

--
error compiling committee.c: too many arguments to function




reply via email to

[Prev in Thread] Current Thread [Next in Thread]