|
From: | Avi Kivity |
Subject: | Re: [Qemu-devel] [PATCH 11/23] memory: add ioeventfd support |
Date: | Mon, 25 Jul 2011 18:43:12 +0300 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.18) Gecko/20110621 Fedora/3.1.11-1.fc15 Thunderbird/3.1.11 |
On 07/25/2011 06:38 PM, malc wrote:
On Mon, 25 Jul 2011, Avi Kivity wrote: > On 07/25/2011 06:22 PM, malc wrote: > > > > > + } > > > > > + if (a.fd< b.fd) { > > > > > + return true; > > > > > + } else { > > if (a.fd> b.fd) { > > > > > + return false; > > > > > + } > > } > > CODING_STYLE permits braceless else if. The example uses it, the text however suggests it's illegal.
I'll post a patch. It's perfectly reasonable IMO, and there ~1800 instances in the tree.
-- error compiling committee.c: too many arguments to function
[Prev in Thread] | Current Thread | [Next in Thread] |