[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/2] Makefile: distclean should clean all possib
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH 1/2] Makefile: distclean should clean all possible targets |
Date: |
Tue, 26 Jul 2011 08:47:38 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) |
Alexandre Raymond <address@hidden> writes:
> At the moment, "make distclean" relies on the TARGET_DIRS variable, set by
> configure. The problem is that this variable does not always contain all
> possible targets.
>
> For example, the following will leave build data in the tree:
>
> ./configure && make && ./configure --target-list=i386-softmmu \
> && make distclean
>
> as it will only remove the i386-softmmu build directory, although the
> first build created additional directories.
Why is that a problem?
> Solution : pass the full list of targets from configure to make via
> the DEFAULT_TARGET_LIST variable.
Well, I'd expect distclean to remove exactly what *this* makefile can
build, and leave everything else alone.
Your patch adds a special case to that simple rule: also remove
not-configured target directories. Other not-configured stuff is still
left behind.
Special cases need special justification, hence my question above.
- [Qemu-devel] [PATCH 0/2] Minor makefile fixes, Alexandre Raymond, 2011/07/25
- [Qemu-devel] [PATCH 1/2] Makefile: distclean should clean all possible targets, Alexandre Raymond, 2011/07/25
- Re: [Qemu-devel] [PATCH 1/2] Makefile: distclean should clean all possible targets,
Markus Armbruster <=
- Re: [Qemu-devel] [PATCH 1/2] Makefile: distclean should clean all possible targets, Alexandre Raymond, 2011/07/26
- Re: [Qemu-devel] [PATCH 1/2] Makefile: distclean should clean all possible targets, Markus Armbruster, 2011/07/27
- Re: [Qemu-devel] [PATCH 1/2] Makefile: distclean should clean all possible targets, Alexandre Raymond, 2011/07/27
- Re: [Qemu-devel] [Qemu-trivial] [PATCH 1/2] Makefile: distclean should clean all possible targets, Michael Roth, 2011/07/27
- Re: [Qemu-devel] [Qemu-trivial] [PATCH 1/2] Makefile: distclean should clean all possible targets, Paolo Bonzini, 2011/07/29
[Qemu-devel] [PATCH 2/2] Makefile: delete config.log in distclean, Alexandre Raymond, 2011/07/25