[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 33/55] ide/atapi: Avoid physical/virtual tray st
From: |
Christoph Hellwig |
Subject: |
Re: [Qemu-devel] [PATCH 33/55] ide/atapi: Avoid physical/virtual tray state mismatch |
Date: |
Tue, 26 Jul 2011 14:17:22 +0200 |
User-agent: |
Mutt/1.5.17 (2007-11-01) |
On Wed, Jul 20, 2011 at 06:24:07PM +0200, Markus Armbruster wrote:
> When ide-cd is backed by a physical drive, we want the physical tray
> match the virtual one. To that end, we call bdrv_eject() on guest's
> load/eject, and bdrv_lock_medium() on guest's prevent/allow removal.
> But we don't set the initial state on device model init. Fix that.
>
> While there, also unlock on device model exit.
Looks good,
Reviewed-by: Christoph Hellwig <address@hidden>
But wondering: do you actually use the physical CDROM passthrough?
- [Qemu-devel] [PATCH 14/55] ide: Reject ATA commands specific to drive kinds, (continued)
- [Qemu-devel] [PATCH 33/55] ide/atapi: Avoid physical/virtual tray state mismatch, Markus Armbruster, 2011/07/20
- Re: [Qemu-devel] [PATCH 33/55] ide/atapi: Avoid physical/virtual tray state mismatch,
Christoph Hellwig <=
- [Qemu-devel] [PATCH 03/55] block: Attach non-qdev devices as well, Markus Armbruster, 2011/07/20
- [Qemu-devel] [PATCH 11/55] ide: Clean up case label indentation in ide_exec_cmd(), Markus Armbruster, 2011/07/20
- [Qemu-devel] [PATCH 18/55] scsi-disk: Reject CD-specific SCSI commands to disks, Markus Armbruster, 2011/07/20
[Qemu-devel] [PATCH 24/55] ide/atapi: Track tray locked state, Markus Armbruster, 2011/07/20