qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 39/55] block/raw: Fix to forward method bdrv_med


From: Christoph Hellwig
Subject: Re: [Qemu-devel] [PATCH 39/55] block/raw: Fix to forward method bdrv_media_changed()
Date: Tue, 26 Jul 2011 14:18:29 +0200
User-agent: Mutt/1.5.17 (2007-11-01)

On Wed, Jul 20, 2011 at 06:24:13PM +0200, Markus Armbruster wrote:
> Block driver "raw" forwards most methods to the underlying block
> driver.  However, it doesn't implement method bdrv_media_changed().
> Makes bdrv_media_changed() always return -ENOTSUP.
> 
> I believe -fda /dev/fd0 gives you raw over host_floppy, and disk
> change detection (fdc register 7 bit 7) is broken.  Testing my theory
> requires a computer museum, though.

Haha.  The patch looks fine to me anyway,

Reviewed-by: Christoph Hellwig <address@hidden>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]