[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 39/55] block/raw: Fix to forward method bdrv_med
From: |
Christoph Hellwig |
Subject: |
Re: [Qemu-devel] [PATCH 39/55] block/raw: Fix to forward method bdrv_media_changed() |
Date: |
Tue, 26 Jul 2011 14:18:29 +0200 |
User-agent: |
Mutt/1.5.17 (2007-11-01) |
On Wed, Jul 20, 2011 at 06:24:13PM +0200, Markus Armbruster wrote:
> Block driver "raw" forwards most methods to the underlying block
> driver. However, it doesn't implement method bdrv_media_changed().
> Makes bdrv_media_changed() always return -ENOTSUP.
>
> I believe -fda /dev/fd0 gives you raw over host_floppy, and disk
> change detection (fdc register 7 bit 7) is broken. Testing my theory
> requires a computer museum, though.
Haha. The patch looks fine to me anyway,
Reviewed-by: Christoph Hellwig <address@hidden>
- [Qemu-devel] [PATCH 12/55] ide: Fix ATA command READ to set ATAPI signature for CD-ROM, (continued)
- [Qemu-devel] [PATCH 12/55] ide: Fix ATA command READ to set ATAPI signature for CD-ROM, Markus Armbruster, 2011/07/20
- [Qemu-devel] [PATCH 32/55] ide/atapi: Don't fail eject when tray is already open, Markus Armbruster, 2011/07/20
- [Qemu-devel] [PATCH 05/55] block: Split change_cb() into change_media_cb(), resize_cb(), Markus Armbruster, 2011/07/20
- [Qemu-devel] [PATCH 34/55] scsi-disk: Fix START_STOP to fail when it can't eject, Markus Armbruster, 2011/07/20
- [Qemu-devel] [PATCH 39/55] block/raw: Fix to forward method bdrv_media_changed(), Markus Armbruster, 2011/07/20
- Re: [Qemu-devel] [PATCH 39/55] block/raw: Fix to forward method bdrv_media_changed(),
Christoph Hellwig <=
- [Qemu-devel] [PATCH 15/55] ide/atapi: Clean up misleading name in cmd_start_stop_unit(), Markus Armbruster, 2011/07/20
- [Qemu-devel] [PATCH 31/55] ide: Provide IDEDeviceInfo method exit(), Markus Armbruster, 2011/07/20
- [Qemu-devel] [PATCH 23/55] block: Show whether the guest ejected the medium in info block, Markus Armbruster, 2011/07/20
[Qemu-devel] [PATCH 26/55] scsi-disk: Track tray locked state, Markus Armbruster, 2011/07/20