[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 16/23] ioport: register ranges by byte aligned ad
From: |
Avi Kivity |
Subject: |
[Qemu-devel] [PATCH v2 16/23] ioport: register ranges by byte aligned addresses always |
Date: |
Tue, 26 Jul 2011 14:26:15 +0300 |
The I/O port space is byte addressable, even for word and long accesses.
An example is the VMware svga card, which has long ports on offsets 0,
1, and 2.
Reviewed-by: Anthony Liguori <address@hidden>
Signed-off-by: Avi Kivity <address@hidden>
---
ioport.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/ioport.c b/ioport.c
index 0d2611d..a32483b 100644
--- a/ioport.c
+++ b/ioport.c
@@ -146,7 +146,7 @@ int register_ioport_read(pio_addr_t start, int length, int
size,
hw_error("register_ioport_read: invalid size");
return -1;
}
- for(i = start; i < start + length; i += size) {
+ for(i = start; i < start + length; ++i) {
ioport_read_table[bsize][i] = func;
if (ioport_opaque[i] != NULL && ioport_opaque[i] != opaque)
hw_error("register_ioport_read: invalid opaque for address 0x%x",
@@ -166,7 +166,7 @@ int register_ioport_write(pio_addr_t start, int length, int
size,
hw_error("register_ioport_write: invalid size");
return -1;
}
- for(i = start; i < start + length; i += size) {
+ for(i = start; i < start + length; ++i) {
ioport_write_table[bsize][i] = func;
if (ioport_opaque[i] != NULL && ioport_opaque[i] != opaque)
hw_error("register_ioport_write: invalid opaque for address 0x%x",
--
1.7.5.3
- [Qemu-devel] [PATCH v2 09/23] memory: I/O address space support, (continued)
- [Qemu-devel] [PATCH v2 09/23] memory: I/O address space support, Avi Kivity, 2011/07/26
- [Qemu-devel] [PATCH v2 15/23] exec.c: initialize memory map, Avi Kivity, 2011/07/26
- [Qemu-devel] [PATCH v2 05/23] Internal interfaces for memory API, Avi Kivity, 2011/07/26
- [Qemu-devel] [PATCH v2 19/23] pc: move global memory map out of pc_init1() and into its callers, Avi Kivity, 2011/07/26
- [Qemu-devel] [PATCH v2 02/23] Hierarchical memory region API, Avi Kivity, 2011/07/26
- [Qemu-devel] [PATCH v2 07/23] memory: rename MemoryRegion::has_ram_addr to ::terminates, Avi Kivity, 2011/07/26
- [Qemu-devel] [PATCH v2 22/23] sysbus: add MemoryRegion based memory management API, Avi Kivity, 2011/07/26
- [Qemu-devel] [PATCH v2 18/23] pc: convert pc_memory_init() to memory API, Avi Kivity, 2011/07/26
- [Qemu-devel] [PATCH v2 23/23] usb-ohci: convert to MemoryRegion, Avi Kivity, 2011/07/26
- [Qemu-devel] [PATCH v2 20/23] pci: pass address space to pci bus when created, Avi Kivity, 2011/07/26
- [Qemu-devel] [PATCH v2 16/23] ioport: register ranges by byte aligned addresses always,
Avi Kivity <=
- [Qemu-devel] [PATCH v2 21/23] pci: add MemoryRegion based BAR management API, Avi Kivity, 2011/07/26
- [Qemu-devel] [PATCH v2 12/23] memory: add ioeventfd support, Avi Kivity, 2011/07/26
- [Qemu-devel] [PATCH v2 01/23] Add memory API documentation, Avi Kivity, 2011/07/26
- Re: [Qemu-devel] [PATCH v2 00/23] Memory API, batch 1, Anthony Liguori, 2011/07/29