[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 49/55] block: Declare qemu_blockalign() in block
|
From: |
Christoph Hellwig |
|
Subject: |
Re: [Qemu-devel] [PATCH 49/55] block: Declare qemu_blockalign() in block.h, not block_int.h |
|
Date: |
Tue, 26 Jul 2011 15:05:57 +0200 |
|
User-agent: |
Mutt/1.5.17 (2007-11-01) |
On Wed, Jul 20, 2011 at 06:24:23PM +0200, Markus Armbruster wrote:
> Device models should be able to use it without an unclean include of
> block_int.h.
Hmm. We already do proper read-modify-write cycles for actual data
transfers, so killing the buffer inside SD sounds like the better
idea. qemu_blockalign really should be used only for block-layer internal
allocations.
- Re: [Qemu-devel] [PATCH 17/55] ide/atapi: Switch from BlockDriverState's tray_open to own, (continued)
- [Qemu-devel] [PATCH 19/55] scsi-disk: Factor out scsi_disk_emulate_start_stop(), Markus Armbruster, 2011/07/20
- [Qemu-devel] [PATCH 02/55] block: Reset device model callbacks on detach, Markus Armbruster, 2011/07/20
- [Qemu-devel] [PATCH 36/55] ide: Give vmstate structs internal linkage where possible, Markus Armbruster, 2011/07/20
- [Qemu-devel] [PATCH 20/55] scsi-disk: Track tray open/close state, Markus Armbruster, 2011/07/20
- [Qemu-devel] [PATCH 49/55] block: Declare qemu_blockalign() in block.h, not block_int.h, Markus Armbruster, 2011/07/20
- Re: [Qemu-devel] [PATCH 49/55] block: Declare qemu_blockalign() in block.h, not block_int.h,
Christoph Hellwig <=
- [Qemu-devel] [PATCH 50/55] block: New bdrv_set_buffer_alignment(), Markus Armbruster, 2011/07/20
- [Qemu-devel] [PATCH 52/55] block: Move BlockDriverAIOCB & friends from block_int.h to block.h, Markus Armbruster, 2011/07/20
- [Qemu-devel] [PATCH 38/55] scsi-disk: Preserve tray state on migration, Markus Armbruster, 2011/07/20
- [Qemu-devel] [PATCH 51/55] block: Reset buffer alignment on detach, Markus Armbruster, 2011/07/20