Re: [Qemu-devel] [PATCH] virtio-serial-bus: replay guest_open on migration

[Amit Shah]

On (Wed) 27 Jul 2011 [14:09:45], Alon Levy wrote:

> > Also, we'll be lying that a guest opened, since a guest was opened
> > much earlier, before migration.  Nothing has changed as far as the
> > guest is concerned, this is just some host-side tracking that has to
> > be done post-migrate, which belongs in individual devices / ports.
> 
> The callback is there on purpose, some qemu side users exist surely. While
> I understand the lying part about the time, it is worst to lie completely
> by not mentioning the guest has opened the port.

Guest has not re-opened the port.  When the guest opened the port,
spice did get the callback called.  After migration, guest state has
not changed.  Why should you get the callback again?  If you depend on
guest connectedness, after migration, just ensure you do whatever is
necessary.  I think there's no need to involve any other code in this.

                Amit