Re: [Qemu-devel] [PATCH 4/7] Makefile: fix out-of-tree builds

[Stefan Hajnoczi]

On Wed, Jul 27, 2011 at 10:17 AM, Stefan Hajnoczi
<address@hidden> wrote:
> From: Alexandre Raymond <address@hidden>
>
> This patch fixes a minor bugs which prevented QEMU from being built
> out of tree.
>
> Signed-off-by: Alexandre Raymond <address@hidden>
> Signed-off-by: Stefan Hajnoczi <address@hidden>
> ---
>  Makefile |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index eb1c788..cbd614a 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -46,7 +46,7 @@ config-all-devices.mak: $(SUBDIR_DEVICES_MAK)
>
>  -include $(SUBDIR_DEVICES_MAK_DEP)
>
> -%/config-devices.mak: default-configs/%.mak
> +%/config-devices.mak: $(SRC_PATH)/default-configs/%.mak
>        $(call quiet-command,$(SHELL) 
> $(SRC_PATH)/scripts/make_device_config.sh $@ $<, "  GEN   $@")

Agreed, we don't need to explicitly use $(SRC_PATH) since VPATH is set
to the source directory and $< expands to the full path name.  I have
dropped it from the git branch.

Stefan