[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 1/5] balloon: Don't allow multiple balloon handle
From: |
Amit Shah |
Subject: |
[Qemu-devel] [PATCH v2 1/5] balloon: Don't allow multiple balloon handler registrations |
Date: |
Thu, 28 Jul 2011 11:47:12 +0530 |
Multiple balloon devices don't make sense; disallow more than one
registration attempt to register handlers.
Signed-off-by: Amit Shah <address@hidden>
---
balloon.c | 12 ++++++++++--
balloon.h | 4 ++--
2 files changed, 12 insertions(+), 4 deletions(-)
diff --git a/balloon.c b/balloon.c
index a938475..5200565 100644
--- a/balloon.c
+++ b/balloon.c
@@ -36,12 +36,20 @@ static QEMUBalloonEvent *balloon_event_fn;
static QEMUBalloonStatus *balloon_stat_fn;
static void *balloon_opaque;
-void qemu_add_balloon_handler(QEMUBalloonEvent *event_func,
- QEMUBalloonStatus *stat_func, void *opaque)
+int qemu_add_balloon_handler(QEMUBalloonEvent *event_func,
+ QEMUBalloonStatus *stat_func, void *opaque)
{
+ if (balloon_event_fn || balloon_stat_fn || balloon_opaque) {
+ /* We're already registered one balloon handler. How many can
+ * a guest really have?
+ */
+ error_report("Another balloon device already registered");
+ return -1;
+ }
balloon_event_fn = event_func;
balloon_stat_fn = stat_func;
balloon_opaque = opaque;
+ return 0;
}
static int qemu_balloon(ram_addr_t target)
diff --git a/balloon.h b/balloon.h
index a6c31d5..3df14e6 100644
--- a/balloon.h
+++ b/balloon.h
@@ -20,8 +20,8 @@ typedef void (QEMUBalloonEvent)(void *opaque, ram_addr_t
target);
typedef void (QEMUBalloonStatus)(void *opaque, MonitorCompletion cb,
void *cb_data);
-void qemu_add_balloon_handler(QEMUBalloonEvent *event_func,
- QEMUBalloonStatus *stat_func, void *opaque);
+int qemu_add_balloon_handler(QEMUBalloonEvent *event_func,
+ QEMUBalloonStatus *stat_func, void *opaque);
void monitor_print_balloon(Monitor *mon, const QObject *data);
int do_info_balloon(Monitor *mon, MonitorCompletion cb, void *opaque);
--
1.7.6
- [Qemu-devel] [PATCH v2 0/5] balloon: fix memleaks, invalid arguments, unplug, Amit Shah, 2011/07/28
- [Qemu-devel] [PATCH v2 1/5] balloon: Don't allow multiple balloon handler registrations,
Amit Shah <=
- [Qemu-devel] [PATCH v2 2/5] virtio-balloon: Check if balloon registration failed, Amit Shah, 2011/07/28
- [Qemu-devel] [PATCH v2 3/5] balloon: Ignore negative balloon values, Amit Shah, 2011/07/28
- [Qemu-devel] [PATCH v2 4/5] virtio-balloon: Add exit handler, fix memleaks, Amit Shah, 2011/07/28
- Re: [Qemu-devel] [PATCH v2 4/5] virtio-balloon: Add exit handler, fix memleaks, Markus Armbruster, 2011/07/28
- [Qemu-devel] [PATCH v2 5/5] virtio-balloon: Unregister savevm section on device unplug, Amit Shah, 2011/07/28