Re: [Qemu-devel] [PATCH v2 5/5] virtio-balloon: Unregister savevm section on device unplug

[Markus Armbruster]

Amit Shah <address@hidden> writes:

> Migrating after unplugging a virtio-balloon device resulted in an error
> message on the destination:
>
> Unknown savevm section or instance '0000:00:04.0/virtio-balloon' 0
> load of migration failed
>
> Fix this by unregistering the section on device unplug.
>
> Signed-off-by: Amit Shah <address@hidden>
> ---
>  hw/virtio-balloon.c |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/hw/virtio-balloon.c b/hw/virtio-balloon.c
> index 0ce0049..072a88a 100644
> --- a/hw/virtio-balloon.c
> +++ b/hw/virtio-balloon.c
> @@ -45,6 +45,7 @@ typedef struct VirtIOBalloon
>      size_t stats_vq_offset;
>      MonitorCompletion *stats_callback;
>      void *stats_opaque_callback_data;
> +    DeviceState *qdev;
>  } VirtIOBalloon;

All the other virtio device structs already have such a pointer back to
the proxy.  Suggests that it should live in VirtIODevice, and be set up
in generic code.  Again, outside the scope of this series.

I hate the virtio pointer thicket.

[...]