[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] v6 revamp acpitable parsing and allow to specif
|
From: |
Michael Tokarev |
|
Subject: |
Re: [Qemu-devel] [PATCH] v6 revamp acpitable parsing and allow to specify complete (headerful) table |
|
Date: |
Fri, 29 Jul 2011 09:51:56 +0400 |
|
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); en-US; rv:1.9.1.16) Gecko/20110704 Icedove/3.0.11 |
29.07.2011 05:49, Isaku Yamahata wrote:
> On Fri, Jul 15, 2011 at 07:51:43PM +0300, Blue Swirl wrote:
>> On Fri, Jul 15, 2011 at 6:18 PM, John Baboval
>> <address@hidden> wrote:
>>> Is there something I can do to help take this patch the rest of the way?
>>>
>>> I'd hate to see it die because of a style issue and a compiler warning.
>>
>> There's also suspicious missing 'break' statement. How about fixing
>> the issues and submitting the patch?
>
> I fixed the compile error.
Oh, another one? :)
> I think the missing break is intentional, so added an comment there. Michael?
Yes it's intentional, you're right.
> Blue, can you please take a look of it?
I think it's hopeless.
/mjt