Re: [Qemu-devel] [PATCH 49/55] block: Declare qemu_blockalign() in block.h, not block_int.h

[Markus Armbruster]

Christoph Hellwig <address@hidden> writes:

> On Wed, Jul 20, 2011 at 06:24:23PM +0200, Markus Armbruster wrote:
>> Device models should be able to use it without an unclean include of
>> block_int.h.
>
> Hmm.  We already do proper read-modify-write cycles for actual data
> transfers, so killing the buffer inside SD sounds like the better
> idea.  qemu_blockalign really should be used only for block-layer internal
> allocations.

What about the uses in scsi-disk.c and ide/core.c?