Re: [Qemu-devel] [PATCH 05/10] qcow2: Use coroutines

[Stefan Hajnoczi]

On Tue, Jul 26, 2011 at 12:49 PM, Kevin Wolf <address@hidden> wrote:
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
>  block/qcow2-cluster.c |   26 +++---
>  block/qcow2.c         |  240 
> ++++++++++++++++++-------------------------------
>  block/qcow2.h         |    5 +-
>  3 files changed, 102 insertions(+), 169 deletions(-)

I like this.  The only thing that I would like to see is comments
explain what "lock" protects and why.

As I understand it lock is needed because the metadata accesses which
use bdrv_pread() and friends will yield.  So it is necessary to
prevent in-memory qcow2 metadata from getting corrupted during these
operations.

Stefan