|
From: | Paolo Bonzini |
Subject: | Re: [Qemu-devel] [RFC PATCH 0/4] Fix subsection ambiguity in the migration format |
Date: | Fri, 29 Jul 2011 16:49:02 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:5.0) Gecko/20110707 Thunderbird/5.0 |
On 07/29/2011 03:14 PM, Anthony Liguori wrote:
I really hate the idea of changing the migration format moments before the release.
So do I, but that's life.
Since subsections are optional, can't we take the offending subsections, remove them, bump the section version numbers and make the fields required?
The bug happens when you migrate from 0.15 to 0.15, and 0.14 didn't have any subsection for that device. This happens pretty much in all cases that were added to 0.15. It quickly makes a bigger patch than this one, and actually one that's harder to review. At least with this one things can only go _royally_ wrong, and any serious automated test would catch it.
Paolo
[Prev in Thread] | Current Thread | [Next in Thread] |