Re: [Qemu-devel] [PATCH 00/15] sdl: Usability improvements

[Anthony Liguori]

On 07/30/2011 04:39 AM, Jan Kiszka wrote:
> As SDL is my preferred way of working ad-hoc with guests, I had a closer
> look at oddities and shortcomings that this GUI exposed, at least here
> on Linux hosts. The result is a series of patches I've now finally
> polished and completed. Highlights:
>   - fix termination in -no-shutdown mode
>   - fix various issues when switching to/from full screen mode
>   - polish mouse grabbing in full screen mode, under text console and
>     when in absolute mouse mode
>   - dynamically grab keyboard input in absolute mouse mode, enabling
>     e.g. ALT+TAB in the guest
>   - add zoom hot keys to make window scaling more attractive
>   - refactor some ugly functions
>
> Please review/merge.

Reviewed-by: Anthony Liguori <address@hidden>

For the whole series.  I'll merge tomorrow after some testing.

At some point, I need to rebase my gtk backend...

Regards,

Anthony Liguori

> CC: Stefano Stabellini<address@hidden>
>
> Jan Kiszka (15):
>    sdl: Fix termination in -no-shutdown mode
>    sdl: Do not make full screen mode resizable
>    sdl: Avoid redundant scaling deactivation
>    sdl: Properly mark modifier+u as hotkey
>    sdl: Fix full screen toggling from scaled mode
>    sdl: Restore scaling mode on return from full screen
>    sdl: Drop bogus gui_fullscreen_initial_grab
>    sdl: Initialize gui_fullscreen earlier during setup
>    sdl: Consistently avoid grabbing input for text consoles
>    sdl: Never release input while in full screen mode
>    sdl: Fix cursor handling when switching consoles in absolute mouse
>      mode
>    sdl: Dynamically grab input in absolute mouse mode
>    sdl: Add zoom hot keys
>    sdl: Factor out event handlers from sdl_refresh
>    sdl: Refactor sdl_send_mouse_event
>
>   qemu-doc.texi |    8 +
>   ui/sdl.c      |  547 ++++++++++++++++++++++++++++++++++++---------------------
>   2 files changed, 355 insertions(+), 200 deletions(-)