[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Fix duplicate device reset
From: |
Stefan Weil |
Subject: |
Re: [Qemu-devel] [PATCH] Fix duplicate device reset |
Date: |
Mon, 01 Aug 2011 22:45:33 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.18) Gecko/20110617 Thunderbird/3.1.11 |
Am 01.08.2011 13:00, schrieb Isaku Yamahata:
Hi, here is the patch. Can you please give it a try?
From 41039df3174fa46477c4faf93d13eab360dccc22 Mon Sep 17 00:00:00 2001
Message-Id:
<address@hidden>
From: Isaku Yamahata <address@hidden>
Date: Mon, 1 Aug 2011 19:56:42 +0900
Subject: [PATCH] qdev: Fix duplicate reset
qbus_reset_all_fn was registered twice, so a lot of device reset
functions were also called twice when QEMU started.
Which was introduced by 80376c3fc2c38fdd45354e4b0eb45031f35587ed
This patch fixes it by making the main_sytem_bus creation not register
main_system_bus
reset handler.
Cc: Stefan Weil <address@hidden>
Signed-off-by: Isaku Yamahata <address@hidden>
---
hw/qdev.c | 14 ++++++++++++--
1 files changed, 12 insertions(+), 2 deletions(-)
Thanks. I tested your patch with i386-softmmu (bios only)
and with mipsel-softmmu (debian boot / malta).
All registered reset functions were called only once,
and qbus_reset_all_fn was the last one called.
I noticed that there are two functions named piix3_reset.
One might be renamed to piix3_ide_reset, but this is
not related to your patch. There are also two functions
piix4_reset.
Tested-by: Stefan Weil <address@hidden>